Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't build unused DMGs #1231

Merged
merged 1 commit into from
Aug 1, 2018
Merged

don't build unused DMGs #1231

merged 1 commit into from
Aug 1, 2018

Conversation

graphaelli
Copy link
Member

Up for discussion - build time is insignificant but the dependencies (xcode) are not.

simitt
simitt approved these changes Aug 1, 2018
View reviewed changes
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on this. As you pointed out this only removes unused packages and reduces dependencies for running package cmd.

@graphaelli graphaelli merged commit 3b2a876 into elastic:master Aug 1, 2018
@graphaelli graphaelli deleted the no-dmg branch August 1, 2018 14:57
@exekias exekias mentioned this pull request Aug 2, 2018
Merged
@andrewkroh
Copy link
Member

Since you forked your own package.yml you could directly implement these customizations in the YAML file now: https://github.com/elastic/apm-server/blob/master/magefile.go#L111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalvz jalvz jalvz approved these changes

@simitt simitt simitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@graphaelli @andrewkroh @jalvz @simitt