Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apm docs consolidation] Delete moved files, update README #12341

Conversation

colleenmcginnis
Copy link
Contributor

Related to https://github.com/elastic/obs-docs-projects/issues/216

This deletes all docs files that have been moved to the elastic/observability-docs repo's docs/en/observability/apm/ directory. It also updates the README to reflect the changes made throughout the effort to consolidate APM docs in the Observability guide.

The docs-related files that will remain in this repo are:

Note: I also left one image that is used in the dev_docs/ARCHITECTURE.md file.

cc @bmorelli25

@colleenmcginnis colleenmcginnis self-assigned this Jan 3, 2024
Copy link
Contributor

mergify bot commented Jan 4, 2024

This pull request does not have a backport label. Could you fix it @colleenmcginnis? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 4, 2024
@colleenmcginnis
Copy link
Contributor Author

@bmorelli25 can you take a look at the README before I open PRs for other branches?

bmorelli25
bmorelli25 previously approved these changes Jan 4, 2024
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲 bittersweet. Goodbye, APM Server repo.

Copy link
Contributor

mergify bot commented Jan 4, 2024

This pull request is now in conflicts. Could you fix it @colleenmcginnis? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b apm-docs-consolidation-delete-files upstream/apm-docs-consolidation-delete-files
git merge upstream/main
git push upstream apm-docs-consolidation-delete-files

@colleenmcginnis colleenmcginnis marked this pull request as ready for review January 4, 2024 15:38
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner January 4, 2024 15:38
@colleenmcginnis colleenmcginnis merged commit e0c42a5 into elastic:main Jan 4, 2024
10 checks passed
@colleenmcginnis colleenmcginnis deleted the apm-docs-consolidation-delete-files branch January 4, 2024 16:52
@colleenmcginnis colleenmcginnis restored the apm-docs-consolidation-delete-files branch January 4, 2024 17:01
v1v added a commit to v1v/apm-server that referenced this pull request Jan 10, 2024
* feature/patch-release: (249 commits)
  Update release.mk
  [updatecli] Bump elastic stack version to 8.13.0-8upz6ftd (elastic#12380)
  chore: Update to elastic/beats@95f0f85a3edd (elastic#12370)
  ci(release): automate release steps for the minor (elastic#12233)
  build(deps): bump the github-actions group with 1 update (elastic#12365)
  chore: Update to elastic/beats@d1b32774aef4 (elastic#12362)
  [updatecli] Bump elastic stack version to 8.13.0-ybxdr713 (elastic#12349)
  chore: Update to elastic/beats@81ebafc4c2da (elastic#12352)
  [apm docs consolidation] Delete moved files, update README (elastic#12341)
  [updatecli] Bump elastic stack version to 8.13.0-toucn398 (elastic#12325)
  docs: fix incorrect filenames in a document for Windows (elastic#12343)
  chore: Update to elastic/beats@6f192c01ef19 (elastic#12337)
  build(deps): bump golang.org/x/crypto from 0.14.0 to 0.17.0 (elastic#12237)
  Update NOTICE.txt year (elastic#12333)
  build(deps): bump the github-actions group with 1 update (elastic#12322)
  [updatecli] Bump elastic stack version to 8.13.0-4f8l51qr (elastic#12315)
  docs: Update known issues as fix was released (elastic#12196)
  feat: use latest apm-data to set success `event.outcome` when otel span.Status is Unset (elastic#12199)
  [updatecli] Bump elastic stack version to 8.13.0-4aavtlfc (elastic#12304)
  chore: rename apm-mutating-webhook to apm-k8s-attacher (elastic#12222)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants