Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use mage in windows test runner #1301

Merged
merged 3 commits into from
Aug 22, 2018
Merged

use mage in windows test runner #1301

merged 3 commits into from
Aug 22, 2018

Conversation

graphaelli
Copy link
Member

@graphaelli graphaelli commented Aug 20, 2018 •
edited
Loading

uses new capabilities introduced in elastic/beats#7766

closes #1248

@graphaelli graphaelli force-pushed the windows-tests branch 3 times, most recently from f20d6dd to 273bed3 Compare August 20, 2018 20:09
@graphaelli graphaelli changed the title [WIP] use mage in windows test runner use mage in windows test runner Aug 20, 2018
@graphaelli graphaelli requested a review from jalvz August 20, 2018 21:26
@jalvz
Copy link
Contributor

jalvz commented Aug 21, 2018

Thanks @graphaelli for attempting this!

Issue seems to persist: https://apm-ci.elastic.co/job/elastic+apm-server+pull-request+multijob-windows/beat=apm-server,label=windows/1197/console

08:09:05 nosetests : The term 'nosetests' is not recognized as the name of a cmdlet, function, script file, or operable 
08:09:05 program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
08:09:05 At C:\Users\jenkins\workspace\elastic+apm-server+pull-request+multijob-windows\beat\apm-server\label\windows\src\github
08:09:05 .com\elastic\apm-server\script\jenkins\ci.ps1:48 char:8
08:09:05 + exec { nosetests --with-timer --with-xunit --xunit-file=../../build/T ...
08:09:05 +        ~~~~~~~~~
08:09:05     + CategoryInfo          : ObjectNotFound: (nosetests:String) [], CommandNotFoundException
08:09:05     + FullyQualifiedErrorId : CommandNotFoundException

@graphaelli
Copy link
Member Author

@jalvz Sorry, I should have been more clear - this requires some changes to our jenkins infrastructure as well. I have not been able to figure out how to make these fail when ci.ps1 exits with failure.

@jalvz
Copy link
Contributor

jalvz commented Aug 21, 2018

so, there is 2 issues, right?
-failure is reported as success (maybe a runbld issue?)
-the failure itself (nosetests not installed?)

second one is more pushing i think

graphaelli
graphaelli commented Aug 21, 2018
View reviewed changes
script/jenkins/ci.ps1
# Get a CSV list of package names.
$packages = $(go list ./... | select-string -Pattern "/vendor/" -NotMatch | select-string -Pattern "/scripts/cmd/" -NotMatch)
$packages = ($packages|group|Select -ExpandProperty Name) -join ","
exec { go test -race -c -cover -covermode=atomic -coverpkg $packages } "go test FAILURE"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this duplicating mage goTestUnit ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's similar but not identical mage -v goTestUnit runs go test -v ./...

@graphaelli
Copy link
Member Author

jenkins, retest this please. The jenkins infrastructure updates have been deployed. Both issues should be resolved now.

@simitt
Copy link
Contributor

simitt commented Aug 22, 2018

jenkins, retest this please.

@graphaelli graphaelli merged commit 28b2d76 into master Aug 22, 2018
@graphaelli graphaelli deleted the windows-tests branch August 22, 2018 21:07
graphaelli added a commit to graphaelli/apm-server that referenced this pull request Aug 23, 2018
@graphaelli
use mage in windows test runner (elastic#1301)
539610d 
* use mage in windows test runner

* Abort with non zero exit code on errors

* remove elasticsearch dependency from non-integration tests
@graphaelli graphaelli mentioned this pull request Aug 23, 2018
Merged
@graphaelli graphaelli mentioned this pull request Sep 7, 2018
Merged
graphaelli added a commit that referenced this pull request Sep 11, 2018
@graphaelli
Update beats framework to 8f170ac
13dced6 
* partially reverts #1301 since mage goTestUnit has not been backported yet
graphaelli added a commit that referenced this pull request Sep 11, 2018
@graphaelli
partially revert more of #1301
12be16f
@graphaelli graphaelli mentioned this pull request Oct 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalvz jalvz jalvz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Windows tests
3 participants
@graphaelli @jalvz @simitt