Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): update descriptions and use oblt-actions@v1 #13529

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Jul 1, 2024

Motivation/summary

  • Use v1 version for oblt-actions
  • Use oblt-actions rather than apm-pipeline-library <-- it's now deprecated
  • Update the description so it explicitly explains the expected input parameter.

The release.mk is the one in charge of doing the auto-bump:

  • for the patch release:
    NEXT_RELEASE ?= $(RELEASE_BRANCH).$(shell expr $(PROJECT_PATCH_VERSION) + 1)
  • for the minor release:
    NEXT_PROJECT_MINOR_VERSION ?= $(PROJECT_MAJOR_VERSION).$(shell expr $(PROJECT_MINOR_VERSION) + 1).0

Further details

  • .github/workflows/run-patch-release.yml should be run using the main branch and the version to be released.
  • .github/workflows/run-minor-release.yml should be run using the main branch and the current version in main.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@v1v v1v added backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.14 Automated backport with mergify labels Jul 1, 2024
@v1v v1v self-assigned this Jul 1, 2024
@v1v v1v requested a review from a team as a code owner July 1, 2024 10:54
@v1v v1v changed the title Feature/review automation ff ci(release): update descriptions and use oblt-actions@v1 Jul 1, 2024
@v1v v1v requested a review from a team July 1, 2024 10:57
reakaleek
reakaleek previously approved these changes Jul 1, 2024
kruskall
kruskall previously approved these changes Jul 1, 2024
@v1v v1v requested a review from endorama July 1, 2024 12:03
@endorama
Copy link
Member

endorama commented Jul 1, 2024

cc @inge4pres , which is on Release duty

Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v1v
Copy link
Member Author

v1v commented Jul 1, 2024

@v1v could you check this line in the release docs and confirm/change it as needed? 0e77c56/dev_docs/RELEASES.md?plain=1#L19C245-L20C1

Sure, I'll update it now

@v1v v1v dismissed stale reviews from kruskall and reakaleek via 4c8c0d4 July 1, 2024 12:17
@v1v v1v enabled auto-merge (squash) July 1, 2024 12:26
@v1v v1v merged commit daf2ef9 into elastic:main Jul 1, 2024
14 checks passed
mergify bot pushed a commit that referenced this pull request Jul 1, 2024
(cherry picked from commit daf2ef9)

# Conflicts:
#	.github/workflows/run-minor-release.yml
#	.github/workflows/run-patch-release.yml
#	dev_docs/RELEASES.md
mergify bot pushed a commit that referenced this pull request Jul 1, 2024
(cherry picked from commit daf2ef9)

# Conflicts:
#	.github/workflows/run-patch-release.yml
#	dev_docs/RELEASES.md
mergify bot added a commit that referenced this pull request Jul 1, 2024
…port #13529) (#13532)

* ci(release): update descriptions and use oblt-actions@v1 (#13529)

(cherry picked from commit daf2ef9)

# Conflicts:
#	.github/workflows/run-patch-release.yml
#	dev_docs/RELEASES.md

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
mergify bot added a commit that referenced this pull request Jul 1, 2024
…port #13529) (#13531)

* ci(release): update descriptions and use oblt-actions@v1 (#13529)

(cherry picked from commit daf2ef9)

# Conflicts:
#	.github/workflows/run-minor-release.yml
#	.github/workflows/run-patch-release.yml
#	dev_docs/RELEASES.md

* Apply suggestions from code review

---------

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.14 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants