udpatecli: support bump golang for 7.17 #13559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @v1v? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
v1v
added
backport-7.17
reakaleek
approved these changes
Jul 3, 2024
kruskall
approved these changes
Jul 3, 2024
v1v
commented
Jul 3, 2024
Comment on lines
+29
to
+31
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: '7.17' |
There was a problem hiding this comment.
This is the reason I cannot test my changes using a feature branch and I also need to backport the changes to 7.17.
mergify bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
(cherry picked from commit 6e8f871) # Conflicts: # .github/workflows/bump-golang.yml
2 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
(cherry picked from commit 6e8f871) # Conflicts: # .github/workflows/bump-golang.yml
2 tasks
mergify bot
added a commit
that referenced
this pull request
Jul 3, 2024
) * udpatecli: support bump golang for 7.17 (#13559) (cherry picked from commit 6e8f871) # Conflicts: # .github/workflows/bump-golang.yml * Apply suggestions from code review --------- Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Jul 3, 2024
) * udpatecli: support bump golang for 7.17 (#13559) (cherry picked from commit 6e8f871) # Conflicts: # .github/workflows/bump-golang.yml * Apply suggestions from code review --------- Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
7.17 branch uses a different go-version, let's enable the auto-bump
Checklist
For functional changes, consider:
How to test these changes
Locally using the
updateclior in the CI using a feature branch:But it requires to checkout the 7.17 branch too, so we need to test it out after merging it
Related issues