[7.x] Fix minor diff to master #3546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation `nonzero` is broken with latest beats update. Temporarily implement validation instead of using validation tags until elastic/go-ucfg#147 is fixed. backports commit f604f27
Codecov Report
@@ Coverage Diff @@
## 7.x #3546 +/- ##
=======================================
Coverage 79.31% 79.31%
=======================================
Files 109 109
Lines 5839 5839
=======================================
Hits 4631 4631
Misses 1208 1208 |
graphaelli
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
This backports some minor changes from
masterto7.xto keep diffs smal.Checklist
- [ ] I have signed the Contributor License Agreement.- [ ] My code follows the style guidelines of this project (runmake check-fullfor static code checks and linting)- [ ] I have made corresponding changes to the documentation- [ ] I have updated CHANGELOG.asciidocHow to test these changes
Related issues