Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format to transaction.duration.us #3771

Closed
wants to merge 1 commit into from

Conversation

simitt
Copy link
Contributor

@simitt simitt commented May 7, 2020

Motivation/summary

Adds input- and output-format and precision to transaction.duration.us for improved usability and

What's controversal here is that we format a field that has us in its name to milliseconds.

Checklist

- [ ] I have signed the Contributor License Agreement.

  • My code follows the style guidelines of this project (run make check-full for static code checks and linting)
  • I have rebased my changes on top of the latest master branch

- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works

  • New and existing unit tests pass locally with my changes

How to test these changes

  1. Check out a local copy of Kibana and update the index pattern to contain the new format; start Kibana and add APM data
  2. navigate through APM UI and check out implications on Kibana data for transaction.duration.us.

Related issues

implements #3751

@simitt simitt requested a review from a team May 7, 2020 12:28
@simitt
Copy link
Contributor Author

simitt commented May 7, 2020

Actually we have specifically removed the format from the field previously (#1717) to avoid confusion around showing duration from a us field as milliseconds. So most probably we should not apply this change here and rather close the PR.

@apmmachine
Copy link
Contributor

apmmachine commented May 7, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-05-08T18:51:48.483+0000

  • Duration: 48 min 12 sec (2892455)

  • Commit: b0b32fc

Test stats 🧪

Test Results
Failed 0
Passed 3222
Skipped 145
Total 3367

Steps errors

Expand to view the steps failures

  • Name: Test Sync
    • Description: ./script/jenkins/sync.sh

    • Result: FAILURE

    • Duration: 3 min 51 sec

    • Start Time: 2020-05-08T19:02:46.329+0000

    • log

@simitt
Copy link
Contributor Author

simitt commented May 14, 2020

Closing this out based on discussions in the related issue #3751

@simitt simitt closed this May 14, 2020
@simitt simitt deleted the index-pattern-format branch June 2, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants