Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update documentation copied from Beats #3793

Merged
merged 3 commits into from
May 14, 2020

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented May 13, 2020

Motivation/summary

This PR updates the shared Beats documentation. It also adds documentation for Kerberos, including proposed changes to APM Server's yml config files in 1cb76a6. Based on elastic/beats#16871 and elastic/beats#17927, kerberos settings have been added to the Elasticsearch output, Kafka output, and X-pack Monitoring sections of those files.

Related issues

For https://github.com/elastic/observability-dev/issues/833.

@bmorelli25 bmorelli25 requested a review from a team May 13, 2020 20:34
@bmorelli25 bmorelli25 self-assigned this May 13, 2020
Comment on lines +238 to +243
[float]
==== `logging.ecs`

When true, logs messages with minimal required Elastic Common Schema (ECS)
information.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3749 was merged into 7.x, not master. Is this ok to have in master?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty certain it is. @simitt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is, sorry I forgot to follow up with it in master.

@codecov-io
Copy link

Codecov Report

Merging #3793 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3793   +/-   ##
=======================================
  Coverage   79.84%   79.84%           
=======================================
  Files         136      136           
  Lines        6158     6158           
=======================================
  Hits         4917     4917           
  Misses       1241     1241           

@apmmachine
Copy link
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 3227
Skipped 145
Total 3372

@bmorelli25 bmorelli25 merged commit f49b20d into elastic:master May 14, 2020
@bmorelli25 bmorelli25 deleted the 7.8-update-beats-docs branch May 14, 2020 20:33
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request May 14, 2020
# Conflicts:
#	docs/copied-from-beats/docs/loggingconfig.asciidoc
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request May 14, 2020
# Conflicts:
#	docs/copied-from-beats/docs/loggingconfig.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants