Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to elastic/beats@abd6a93bf275 #5082

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Update to elastic/beats@abd6a93bf275 #5082

merged 2 commits into from
Apr 13, 2021

Conversation

axw
Copy link
Member

@axw axw commented Apr 13, 2021

Motivation/summary

Update beats. This brings in elastic/beats#24964.

How to test these changes

  1. Install apm-server (don't just make apm-server, this is a shortcut for development and does not build PIE)
  2. Check the binary is PIE (see https://unix.stackexchange.com/questions/89211/how-to-test-whether-a-linux-binary-was-compiled-as-position-independent-code)

Related issues

Closes #4960

@apmmachine
Copy link
Contributor

apmmachine commented Apr 13, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #5082 updated

  • Start Time: 2021-04-13T05:18:03.148+0000

  • Duration: 38 min 13 sec

  • Commit: b633a7a

Test stats 🧪

Test Results
Failed 0
Passed 6274
Skipped 120
Total 6394

Trends 🧪

Image of Build Times

Image of Tests

@axw axw marked this pull request as ready for review April 13, 2021 05:59
@axw axw requested a review from a team April 13, 2021 05:59
Copy link
Contributor

@stuartnelson3 stuartnelson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# go build -buildmode=pie -o apm-server-pie ./x-pack/apm-server
# hardening-check apm-server-pie
apm-server-pie:
 Position Independent Executable: yes
 Stack protected: yes
 Fortify Source functions: yes (some protected functions found)
 Read-only relocations: yes
 Immediate binding: yes
 Stack clash protection: unknown, no -fstack-clash-protection instructions found
 Control flow integrity: no, not found!

🥳

assert.Equal(t, tc.policiesLoaded, len(clientHandler.policies), "policies")
assert.Equal(t, tc.aliasesLoaded, len(clientHandler.aliases), "aliases")
assert.Len(t, clientHandler.policies, tc.policiesLoaded)
assert.Len(t, clientHandler.aliases, tc.aliasesLoaded)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@axw axw merged commit bb856fc into elastic:master Apr 13, 2021
@axw axw deleted the update-beats branch April 13, 2021 07:04
@tonymeehan
Copy link

Wooo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use -buildmode=pie (position independence executable)
4 participants