Remove apm-server.decoder.* metrics

[axw]

Motivation/summary

These are not used by stack monitoring, and I don't think they have ever been useful for supportability, so let's remove them.

Checklist

• Update CHANGELOG.asciidoc
  - [ ] Update package changelog.yml (only if changes to apmpackage have been made)
  - [ ] Documentation has been updated

How to test these changes

N/A

Related issues

Closes #9079

[apmmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-09-27T10:45:42.500+0000

• Duration: 27 min 9 sec

Test stats 🧪

Test	Results
Failed	0
Passed	148
Skipped	0
Total	148

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate and publish the docker images.

• /test windows : Build & tests on Windows.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[apmmachine]

📚 Go benchmark report

Diff with the main branch

name                                                                                              old time/op    new time/op     delta
pkg:github.com/elastic/apm-server/internal/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/beater/request goos:linux goarch:amd64
ContextReset/Remote_Addr_ipv6-12                                                                     848ns ±14%      535ns ±51%  -36.92%  (p=0.016 n=5+5)
ContextReset/X-Forwarded-For_ipv4-12                                                                 953ns ±11%      717ns ±33%  -24.75%  (p=0.032 n=5+5)
ContextReset/Forwarded_ipv4-12                                                                      1.03µs ± 5%     0.75µs ±59%  -27.88%  (p=0.008 n=5+5)
ContextReset/X-Real-IP_ipv4-12                                                                       991ns ±23%      592ns ±38%  -40.19%  (p=0.016 n=5+5)
ContextReset/Remote_Addr_ipv4-12                                                                     843ns ± 7%      604ns ±54%  -28.38%  (p=0.016 n=5+5)
ContextResetContentEncoding/empty-12                                                                 148ns ± 1%      130ns ± 1%  -12.49%  (p=0.008 n=5+5)
ContextResetContentEncoding/uncompressed-12                                                          167ns ± 1%      157ns ± 1%   -6.24%  (p=0.008 n=5+5)
ContextResetContentEncoding/gzip_sniff-12                                                           4.10µs ± 2%     3.32µs ±32%  -19.14%  (p=0.032 n=5+5)
ContextResetContentEncoding/deflate_sniff-12                                                        3.98µs ± 4%     2.93µs ±65%  -26.45%  (p=0.032 n=5+5)
pkg:github.com/elastic/apm-server/internal/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessor/transactions-huge_traces.ndjson-12                                                 44.5µs ±18%     52.5µs ±14%  +18.01%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/metricsets.ndjson-12                    15.3µs ± 6%     14.3µs ± 3%   -6.64%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/transactions-huge_traces.ndjson-12      18.2µs ±15%     16.0µs ± 5%  -11.70%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/transactions_spans_rum.ndjson-12        6.08µs ±12%     5.32µs ± 6%  -12.56%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/invalid-json-event.ndjson-12            1.42µs ± 1%     1.45µs ± 2%   +2.25%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/otel-bridge.ndjson-12                   3.76µs ± 1%     3.88µs ± 3%   +3.33%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/heavy.ndjson-12                        504µs ± 3%      550µs ± 9%   +9.09%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/unknown-span-type.ndjson-12           6.13µs ± 1%     6.37µs ± 6%   +3.98%  (p=0.032 n=5+5)
ReadBatch/invalid-json-metadata.ndjson-12                                                           40.6µs ±29%     25.3µs ±37%  -37.65%  (p=0.032 n=5+5)
pkg:github.com/elastic/apm-server/internal/publish goos:linux goarch:amd64
Publisher-12                                                                                         1.00s ± 0%      1.00s ± 0%   -0.14%  (p=0.032 n=5+5)
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
AggregateTransaction-12                                                                             83.7ns ± 1%     85.8ns ± 3%   +2.49%  (p=0.016 n=5+5)
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64
WriteTransaction/json_codec-12                                                                      6.47µs ±34%     9.31µs ± 5%  +43.83%  (p=0.016 n=5+4)

name                                                                                              old alloc/op   new alloc/op    delta
pkg:github.com/elastic/apm-server/internal/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/beater/request goos:linux goarch:amd64
ContextReset/Remote_Addr_ipv6-12                                                                      384B ± 0%       352B ± 0%   -8.33%  (p=0.008 n=5+5)
ContextReset/X-Forwarded-For_ipv4-12                                                                  384B ± 0%       352B ± 0%   -8.33%  (p=0.008 n=5+5)
ContextReset/X-Forwarded-For_ipv6-12                                                                  384B ± 0%       352B ± 0%   -8.33%  (p=0.008 n=5+5)
ContextReset/Forwarded_ipv4-12                                                                        384B ± 0%       352B ± 0%   -8.33%  (p=0.008 n=5+5)
ContextReset/Forwarded_ipv6-12                                                                        384B ± 0%       352B ± 0%   -8.33%  (p=0.008 n=5+5)
ContextReset/X-Real-IP_ipv4-12                                                                        384B ± 0%       352B ± 0%   -8.33%  (p=0.008 n=5+5)
ContextReset/X-Real-IP_ipv6-12                                                                        384B ± 0%       352B ± 0%   -8.33%  (p=0.008 n=5+5)
ContextReset/Remote_Addr_ipv4-12                                                                      384B ± 0%       352B ± 0%   -8.33%  (p=0.008 n=5+5)
pkg:github.com/elastic/apm-server/internal/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessor/optional-timestamps.ndjson-12                                                      4.49kB ± 1%     4.46kB ± 0%   -0.67%  (p=0.048 n=5+4)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/errors_transaction_id.ndjson-12         20.0kB ± 1%     19.8kB ± 1%   -1.24%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/invalid-metadata.ndjson-12              3.16kB ± 2%     3.22kB ± 2%   +1.90%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/errors_2.ndjson-12                      25.1kB ± 0%     24.8kB ± 1%   -1.16%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/logs.ndjson-12                          9.30kB ± 0%     9.24kB ± 1%   -0.68%  (p=0.048 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/invalid-json-event.ndjson-12            4.79kB ± 1%     4.76kB ± 1%   -0.71%  (p=0.040 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metricsets.ndjson-12                  14.0kB ± 1%     13.7kB ± 4%   -2.31%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/ratelimit.ndjson-12                   11.9kB ± 1%     11.7kB ± 1%   -2.31%  (p=0.008 n=5+5)
ReadBatch/invalid-metadata.ndjson-12                                                                5.81kB ± 0%     5.81kB ± 0%   -0.02%  (p=0.016 n=5+4)
pkg:github.com/elastic/apm-server/internal/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64
ReadEvents/json_codec/199_events-12                                                                 1.10MB ± 0%     1.10MB ± 0%   -0.05%  (p=0.040 n=5+5)

name                                                                                              old allocs/op  new allocs/op   delta
pkg:github.com/elastic/apm-server/internal/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/beater/request goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/errors_transaction_id.ndjson-12            349 ± 0%        348 ± 0%   -0.29%  (p=0.000 n=5+4)
ReadBatch/events.ndjson-12                                                                             713 ± 0%        714 ± 0%   +0.14%  (p=0.016 n=4+5)
pkg:github.com/elastic/apm-server/internal/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64

name                                                                                              old speed      new speed       delta
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessor/transactions-huge_traces.ndjson-12                                               72.1MB/s ±21%   60.9MB/s ±15%  -15.42%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/metricsets.ndjson-12                   166MB/s ± 6%    178MB/s ± 3%   +7.00%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/transactions-huge_traces.ndjson-12     176MB/s ±13%    198MB/s ± 5%  +12.50%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/transactions_spans_rum.ndjson-12       191MB/s ±11%    218MB/s ± 6%  +13.64%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/invalid-json-event.ndjson-12           413MB/s ± 1%    404MB/s ± 2%   -2.18%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/otel-bridge.ndjson-12                  501MB/s ± 1%    485MB/s ± 3%   -3.19%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/heavy.ndjson-12                      792MB/s ± 3%    729MB/s ± 9%   -7.98%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/unknown-span-type.ndjson-12          540MB/s ± 1%    519MB/s ± 6%   -3.72%  (p=0.032 n=5+5)
ReadBatch/invalid-json-metadata.ndjson-12                                                         11.4MB/s ±37%   18.9MB/s ±48%  +65.47%  (p=0.032 n=5+5)

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

[simitt]

Verified with BC5 on cloud that apm-server.decoder.* metrics are not part of the metrics collection anymore.