updated session.id and telemetry.sdk.elastic_export_timestamp #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specs/agents/mobile/README.md
Outdated
| | [`device.manufacturer`](https://opentelemetry.io/docs/reference/specification/resource/semantic_conventions/device/) | `device.manufacturer` | `Apple`, `Samsung` | :x: no | This information is potentially not directly available on the device and needs to be derived / mapped from `device.model.identifier`. In this case, the APM server should do the mapping. | | ||
| | [`process.runtime.name`](https://opentelemetry.io/docs/reference/specification/resource/semantic_conventions/process/#process-runtimes) | `service.runtime.name` | `Android Runtime` | :x: no | Use `Android Runtime` for Android. For iOS use `iOS`. | | ||
| | [`process.runtime.version`](https://opentelemetry.io/docs/reference/specification/resource/semantic_conventions/process/#process-runtimes) | `service.runtime.version` | `2.0.1` | :x: no | Use the Dalvik version for Android (`System.getProperty("java.vm.version")`). For iOS use the version of iOS. | | ||
| | `session.id` | `session.id` | `A73DC41E-DF18-4BB4-ABC0-F0000FD95653` | :x: no | | |
There was a problem hiding this comment.
Is the iOS agent setting session.id in the OTel resources? Because at the moment the Android one is just adding it as a regular, dynamic attr.
There was a problem hiding this comment.
No, I'm not, but for lack of a better place for this attribute, I threw it in this table. It's probably more appropriate from a categorization perspective to put it in it's own table, but I'm not sure if there's a term in open-telemetry for a non-resource attribute that applies to all signals.
There was a problem hiding this comment.
Oh! Got it, makes sense. I just wanted to double-check because it was a bit confusing to see it under the resource attrs, though I see what you mean, it's not clear what table it should go to.
LikeTheSalad
approved these changes
Dec 19, 2023
This was referenced Jan 16, 2024
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CODEOWNERS)To auto-merge the PR, add
/schedule YYYY-MM-DDto the PR description./schedule 2023-12-15