Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that Beat ships with the right binary #105

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Jan 7, 2019

New check for all beats:

  • If package is oss: checks that help enroll fails.
  • If package is x-pack: check that help enroll doesn't fail.

This test is put to prevent cases where the wrong binary is packaged (i.e. the oss binary in the x-pack distribution).

Test only works on 6.5+ due to the enroll command being first available in v6.5.0.

New check for all beats:
- If package is oss: checks that help enroll fails.
- If package is x-pack: check that help enroll doesn't fail.

This test is put to prevent cases where the wrong binary is packaged
(i.e. the oss binary in the x-pack distribution).

Test only works on 6.5+ due to the enroll command being first available
in v6.5.0.
@adriansr
Copy link
Contributor Author

adriansr commented Jan 7, 2019

Still testing it, not sure about Windows. works for me.

@adriansr adriansr added the review label Jan 7, 2019
@adriansr adriansr merged commit 4ee17c4 into elastic:master Jan 7, 2019
This was referenced Jun 15, 2021
ChrsMark added a commit that referenced this pull request Jun 15, 2021
v1v added a commit to v1v/beats-tester that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants