Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetricBeat]keep tags original value, DeDot is not unnecessary? #19112

Closed
kwinstonix opened this issue Jun 10, 2020 · 2 comments · Fixed by #19221
Closed

[MetricBeat]keep tags original value, DeDot is not unnecessary? #19112

kwinstonix opened this issue Jun 10, 2020 · 2 comments · Fixed by #19221
Assignees
Labels
Team:Platforms Label for the Integrations - Platforms team

Comments

@kwinstonix
Copy link
Contributor

Describe a specific use case for the enhancement or feature:

tags value may contain dot, eg: IPv4 address. I think It is safe to include dots in the tag value.

tags := resourceTagMap[v]
if len(tags) != 0 {
// By default, replace dot "." using underscore "_" for tag keys and values
for _, tag := range tags {
events[identifier].RootFields.Put("aws.tags."+common.DeDot(*tag.Key), common.DeDot(*tag.Value))
}
continue
}

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 10, 2020
@kwinstonix kwinstonix changed the title [MetricBeat]keep tags origin value, DeDot is not unnecessary? [MetricBeat]keep tags original value, DeDot is not unnecessary? Jun 10, 2020
@ycombinator ycombinator added the Team:Platforms Label for the Integrations - Platforms team label Jun 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 10, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 16, 2020
@kaiyan-sheng
Copy link
Contributor

Hi @kwinstonix, thanks for opening this issue! You are right, we only need to dedot for tag key, which will be the json field name in Elasticsearch. I will push a PR to fix this soon. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants