Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Remove dedot for AWS tag value #19221

Merged
merged 5 commits into from
Jun 17, 2020
Merged

[Metricbeat] Remove dedot for AWS tag value #19221

merged 5 commits into from
Jun 17, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jun 16, 2020 •
edited
Loading

What does this PR do?

This PR is to remove dedotting when collecting AWS tag value. Only tag keys are dedotted, but keep tag values to be the original.

Why is it important?

For some use cases, tags value may contain dot, such as IPv4 address. There is no need to dedot when storing into ES in json event field value.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Screenshots

This is before and after comparison for tag value:
Screen Shot 2020-06-16 at 11 00 22 AM

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 16, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 16, 2020
@kaiyan-sheng kaiyan-sheng added bug needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team labels Jun 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 16, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 16, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19221 updated]

  • Start Time: 2020-06-17T13:12:56.323+0000

  • Duration: 72 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 1243
Skipped 199
Total 1442

ChrsMark
ChrsMark approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

x-pack/metricbeat/module/aws/ec2/ec2.go Outdated Show resolved Hide resolved
x-pack/metricbeat/module/aws/rds/rds.go Outdated Show resolved Hide resolved
@kaiyan-sheng kaiyan-sheng merged commit e491c8d into elastic:master Jun 17, 2020
@kaiyan-sheng kaiyan-sheng deleted the tag_value branch June 17, 2020 15:47
@kaiyan-sheng kaiyan-sheng mentioned this pull request Jun 17, 2020
Merged
6 tasks
@kaiyan-sheng kaiyan-sheng added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jun 17, 2020
@kaiyan-sheng kaiyan-sheng mentioned this pull request Jun 17, 2020
Merged
6 tasks
kaiyan-sheng added a commit that referenced this pull request Jun 18, 2020
@kaiyan-sheng
Cherry-pick #19221 to 7.8: [Metricbeat] Remove dedot for AWS tag value (
30d1760 
#19251)

* [Metricbeat] Remove dedot for AWS tag value (#19221)

* Remove dedot for AWS tag value

(cherry picked from commit e491c8d)
kaiyan-sheng added a commit that referenced this pull request Jun 18, 2020
@kaiyan-sheng
Cherry-pick #19221 to 7.x: [Metricbeat] Remove dedot for AWS tag value (
c14e412 
#19250)

* [Metricbeat] Remove dedot for AWS tag value (#19221)

* Remove dedot for AWS tag value

(cherry picked from commit e491c8d)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@kaiyan-sheng @melchiormoulin
[Metricbeat] Remove dedot for AWS tag value (elastic#19221)
5853610 
* Remove dedot for AWS tag value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
bug review Team:Platforms Label for the Integrations - Platforms team v7.8.0 v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MetricBeat]keep tags original value, DeDot is not unnecessary?
3 participants
@kaiyan-sheng @elasticmachine @ChrsMark