Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSuite] Rename module to Google Workspace #22427

Closed
jamiehynds opened this issue Nov 4, 2020 · 12 comments · Fixed by #22950
Closed

[GSuite] Rename module to Google Workspace #22427

jamiehynds opened this issue Nov 4, 2020 · 12 comments · Fixed by #22950
Assignees

Comments

@jamiehynds
Copy link

jamiehynds commented Nov 4, 2020

Google recently rebranded G Suite to 'Google Workspace' and we need to reflect this change in our Filebeat module and associated docs.

@threat-punter is building detection rules for G Suite, so will need to make sure he's kept in the loop on our rename to Workspace.

We'll also need to ensure the correct logo is used when we create a package: https://lh3.googleusercontent.com/sYGCKFdty43En6yLGeV94mfNGHXfVj-bQYitHRndarB7tHmQq_kyVxhlPejeCBVEEYUbnKG2_jUzgNXoPoer6XJm71V3uz2Z6q0CmNw=w0

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@jamiehynds
Copy link
Author

FYI @marc-gr

@marc-gr marc-gr self-assigned this Nov 5, 2020
@threat-punter
Copy link

Thanks for the heads up @jamiehynds. I used the "Google Workspace" term in all of our new rules.

One thing that I'll need to do if we have a Fleet Integration is to add that index pattern to our rules.

@jamiehynds
Copy link
Author

@threat-punter I noticed the new rules all reference event.dataset:gsuite.admin - do you have a preference towards keeping the modules dataset as gsuite? We were thinking of updating to workspace to ensure we're inline with the rebrand.

We're probably going to encounter a similar issue with O365 to M365 too: elastic/detection-rules#668

@threat-punter
Copy link

Ah, good point @jamiehynds. I'm on board with renaming it to the new name and I can take care of modifying the rules when the time comes

@threat-punter
Copy link

Will events indexed by the Google Workspace module still have the event.dataset value of gsuite.admin? I'm not sure if this change will be made by us or Google. If it changes, will need to update our detection rules accordingly.

@marc-gr
Copy link
Contributor

marc-gr commented Dec 16, 2020

Will events indexed by the Google Workspace module still have the event.dataset value of gsuite.admin? I'm not sure if this change will be made by us or Google. If it changes, will need to update our detection rules accordingly.

We duplicated the module so events that are still using a previously configured Gsuite module will get gsuite.admin as before. If someone configures the new Google Workspace one they will get google_workspace.admin then, since this is set by filebeat based on the module name+fileset iirc. Hope that answers your question 👍

@jamiehynds
Copy link
Author

@marc-gr am I correct in saying that the detection rules should be updated so that 'event.dataset: gsuite.admin OR google_workspace.admin'? That would then provide coverage regardless of which module the user is running?

@marc-gr
Copy link
Contributor

marc-gr commented Dec 16, 2020

@marc-gr am I correct in saying that the detection rules should be updated so that 'event.dataset: gsuite.admin OR google_workspace.admin'? That would then provide coverage regardless of which module the user is running?

That is correct 👍

@threat-punter
Copy link

Thanks @jamiehynds and @marc-gr. I'll open a PR to amend our derules.

@threat-punter
Copy link

Thanks @jamiehynds and @marc-gr. I'll open a PR to amend our detection rules.

@threat-punter
Copy link

I added the above changes to @bm11100's PR here: elastic/detection-rules#729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants