Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22950 to 7.x: [Filebeat] Deprecate Gsuite module and create Google Workspace one #23108

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Dec 14, 2020

Cherry-pick of PR #22950 to 7.x branch. Original message:

What does this PR do?

  • Creates new module Google Workspace (copy from Gsuite but renaming any gsuite to google_workspace)
  • Adds deprecation comment on Gsuite module
  • Changes Google Workspace config to work with the new HTTPJSON config

Why is it important?

To be aligned with new Google rebranding from GSuite to Google Workspace.

To prevent users custom rules to break on the module renaming, we decided to duplicate it for a release while they migrate to the new one, instead of directly doing a rename which would be a breaking change.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 14, 2020
@marc-gr marc-gr requested a review from a team December 14, 2020 16:07
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 14, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23108 updated

  • Start Time: 2020-12-14T17:37:27.119+0000

  • Duration: 47 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 5107
Skipped 576
Total 5683

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 5107
Skipped 576
Total 5683

…lastic#22950)

* Deprecate Gsuite module and create Google Workspace one

* Update with latest gsuite changes

* Use deprecation tag and fix doc typo

(cherry picked from commit 4540460)
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr merged commit def4c4f into elastic:7.x Dec 15, 2020
@marc-gr marc-gr deleted the backport_22950_7.x branch December 15, 2020 09:26
@zube zube bot removed the [zube]: Done label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants