[Heartbeat] Disabled monitors in static monitor list cause crash #27599
Assignees
Labels
Comments
botelastic
bot
added
the
needs_team
|
This issue doesn't have a |
andrewvc
added a commit
to andrewvc/beats
that referenced
this issue
Aug 26, 2021
Fixes elastic#27599 This properly handles skipped monitors, and also fixes the broken test for this. Additionally, this switches to the go1.3+ way of handling error hierarchies in `heartbeat.go` using `errors.Is`. It also cleans up the code by no longer making a disabled config an `error` when parsing stdfields. It's now only an error when detected in `monitor.go` which is cleaner.
6 tasks
andrewvc
added a commit
that referenced
this issue
Aug 26, 2021
Fixes #27599 This properly handles skipped monitors, and also fixes the broken test for this. Additionally, this switches to the go1.3+ way of handling error hierarchies in `heartbeat.go` using `errors.Is`. It also cleans up the code by no longer making a disabled config an `error` when parsing stdfields. It's now only an error when detected in `monitor.go` which is cleaner.
mergify bot
pushed a commit
that referenced
this issue
Aug 26, 2021
Fixes #27599 This properly handles skipped monitors, and also fixes the broken test for this. Additionally, this switches to the go1.3+ way of handling error hierarchies in `heartbeat.go` using `errors.Is`. It also cleans up the code by no longer making a disabled config an `error` when parsing stdfields. It's now only an error when detected in `monitor.go` which is cleaner. (cherry picked from commit 9a517a7)
mergify bot
pushed a commit
that referenced
this issue
Aug 26, 2021
Fixes #27599 This properly handles skipped monitors, and also fixes the broken test for this. Additionally, this switches to the go1.3+ way of handling error hierarchies in `heartbeat.go` using `errors.Is`. It also cleans up the code by no longer making a disabled config an `error` when parsing stdfields. It's now only an error when detected in `monitor.go` which is cleaner. (cherry picked from commit 9a517a7)
andrewvc
added a commit
that referenced
this issue
Aug 26, 2021
Fixes #27599 This properly handles skipped monitors, and also fixes the broken test for this. Additionally, this switches to the go1.3+ way of handling error hierarchies in `heartbeat.go` using `errors.Is`. It also cleans up the code by no longer making a disabled config an `error` when parsing stdfields. It's now only an error when detected in `monitor.go` which is cleaner. (cherry picked from commit 9a517a7) Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
andrewvc
added a commit
that referenced
this issue
Aug 26, 2021
Fixes #27599 This properly handles skipped monitors, and also fixes the broken test for this. Additionally, this switches to the go1.3+ way of handling error hierarchies in `heartbeat.go` using `errors.Is`. It also cleans up the code by no longer making a disabled config an `error` when parsing stdfields. It's now only an error when detected in `monitor.go` which is cleaner. (cherry picked from commit 9a517a7) Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this issue
Nov 1, 2021
Fixes elastic#27599 This properly handles skipped monitors, and also fixes the broken test for this. Additionally, this switches to the go1.3+ way of handling error hierarchies in `heartbeat.go` using `errors.Is`. It also cleans up the code by no longer making a disabled config an `error` when parsing stdfields. It's now only an error when detected in `monitor.go` which is cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The default config which has an entry with
enabled: falsefor a monitor now crashes heartbeat since refactoring in #27535 . This should be a simple fix.The text was updated successfully, but these errors were encountered: