Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Fix failing python tests on windows #27815

Closed
andrewvc opened this issue Sep 8, 2021 · 2 comments
Closed

[Heartbeat] Fix failing python tests on windows #27815

andrewvc opened this issue Sep 8, 2021 · 2 comments
Assignees
@andrewvc
Labels
Heartbeat needs_team Indicates that the issue/PR needs a Team:* label :Testing v7.16.0

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Sep 8, 2021

The python-based tests for heartbeat's JSON checks, and 404 statuses seem to regularly fail on windows. Specifically:

Extended / heartbeat-windows-2008-windows-2008-r2 / heartbeat.tests.system.test_monitor.Test.test_http_with_hosts_config_1_404
Extended / heartbeat-windows-2008-windows-2008-r2 / heartbeat.tests.system.test_monitor.Test.test_json_simple_comparisons_1__foo_true_

We should look into fixing these. Both of these could probably be moved to go, though its unclear why they specifically are flakey.
@andrewvc andrewvc self-assigned this Sep 8, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 8, 2021
@botelastic
Copy link

botelastic bot commented Sep 8, 2021

This issue doesn't have a Team:<team> label.

andrewvc added a commit to andrewvc/beats that referenced this issue Sep 8, 2021
@andrewvc
[Heartbeat] Move JSON tests from python->go
844f752 
Partial fix for elastic#27815

This moves python tests to go that should have been go in the first
place. Much more maintainable this way.
@andrewvc andrewvc mentioned this issue Sep 8, 2021
Merged
4 tasks
@andrewvc
Copy link
Contributor Author

andrewvc commented Sep 9, 2021

Closing because, after digging deeper, these errors mostly seemed to happen on one day in sept. and must have been due to CI server instability.

@andrewvc andrewvc closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewvc andrewvc

Labels
Heartbeat needs_team Indicates that the issue/PR needs a Team:* label :Testing v7.16.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewvc