Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce service.type field for all Filebeat modules #10042

Merged
merged 5 commits into from
Jan 15, 2019

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Jan 14, 2019

Based on ECS the service.type field is introduce for all Filebeat modules. By default service.type is set to the module name. If the service.type is not the module name the servic.type config can be used in a module to overwrite the field.

The service.name fields in the Elasticsearch module were removed as service.name could be used for example for the cluster name in this context. service.type is the field that always stays the same.

Based on ECS the `service.type` field is introduce for all Filebeat modules. By default `service.type` is set to the module name. If the service.type is not the module name the `servic.type` config can be used in a module to overwrite the field.

The `service.name` fields in the Elasticsearch module were removed as `service.name` could be used for example for the cluster name in this context. `service.type` is the field that always stays the same.
@ruflin ruflin self-assigned this Jan 14, 2019
@ruflin ruflin added the Team:Integrations Label for the Integrations team label Jan 14, 2019
@ruflin ruflin mentioned this pull request Jan 14, 2019
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruflin ruflin merged commit 8a04a80 into elastic:master Jan 15, 2019
@ruflin ruflin deleted the service-type branch January 15, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecs Filebeat Filebeat module review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants