Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auditbeat] Fix skipping processes on permission error #10048

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

cwurm
Copy link
Contributor

@cwurm cwurm commented Jan 14, 2019

A continue statement was accidentally commented out that skipped processes when a permission error occurred. This is common when running as non-root, and not skipping them will lead to the output of a lot of process error documents.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsg
Copy link
Contributor

tsg commented Jan 14, 2019

Is this only needed in the 6.6 branch?

@cwurm
Copy link
Contributor Author

cwurm commented Jan 14, 2019

Is this only needed in the 6.6 branch?

I think so. #9963 will take care of 6.x and master.

@cwurm cwurm merged commit c5336ba into elastic:6.6 Jan 14, 2019
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
A `continue` statement was accidentally commented out that skipped processes when a permission error occurred. This is common when running as non-root, and not skipping them will lead to the output of a lot of process error documents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants