Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DHCPv4 protocol to use ECS fields #10089

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Update DHCPv4 protocol to use ECS fields #10089

merged 2 commits into from
Jan 17, 2019

Commits on Jan 16, 2019

  1. Update DHCPv4 protocol to use ECS fields 

    The DHCPv4 protocol dataset works on uni-flows (it's not transacted, see elastic#7956) so
the `source` and `destination` will indicate the original packet header data. Meanwhile
the `client` / `server` fields are copies of the `source`/`destination`, but they are
copied based on which side is the client and server.

Here's a summary of what fields changed.

Part of elastic#7968

Changed

- bytes_in -> source.bytes
- transport -> network.transport = udp

Added

- source
- destination
- event.dataset = dhcpv4
- event.start
- network.bytes
- network.community_id
- network.protocol = dhcpv4
- network.type

Unchanged Packetbeat Fields

- status
- type = dhcpv4 (we might remove this since we have event.dataset)
    @andrewkroh
    andrewkroh committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    2123e0e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feature/pb/dhcpv4-ecs

    @andrewkroh
    andrewkroh committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    77cf46b View commit details
    Browse the repository at this point in the history