-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish migration to event.duration for 4 Filebeat modules #10274
Conversation
@ycombinator Tweak to event.duration handling for elasticsearch.slowlog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ES slowlog fileset change LGTM. Since it's a breaking change – the elasticsearch.slowlog.took_millis
field is no longer being indexed — worth documenting in the breaking changes section of the CHANGELOG?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
abbebd8
to
d975b1f
Compare
Adding to a changelog like this: kosher? |
Failing libbeat test seems unrelated to me. No field changes here could cause a problem, AFAIK. |
This PR is built on top of #10188 and should not be merged before it.
Please only review commits from Jan 23rd or later.
Filebeat modules affected
Introduced in this PR
ecs-migration.yml
, which mentions thescale
difference between old field andevent.duration
, and marks them asalias: false
.