Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of system network metricset to ECS #10325

Closed
wants to merge 2 commits into from

Conversation

jsoriano
Copy link
Member

@ruflin @webmat current network metricset creates an event with all data, but ECS is intended to have different events for inbound and outbound flows (there is an only network.bytes field).

I try here the approach of splitting events in two, one for inbound and another one for outbound traffic.

Some questions:

  • What to do with fields not present in ECS (dropped and errors), should I leave them in some module-specific field like system.network.dropped? This would be confusing as we'd have related data in different places.
  • What field should be used for the network interface name? I have used network.name by now but seems intended for network names, not for network devices.
  • Is this approach ok or I should migrate only the fields that could help in corelation (the interface name in this case), and leave the rest of fields where they are?

@jsoriano jsoriano added in progress Pull request is currently in progress. module discuss Issue needs further discussion. Metricbeat Metricbeat ecs Team:Integrations Label for the Integrations team labels Jan 24, 2019
@jsoriano jsoriano self-assigned this Jan 24, 2019
@jsoriano jsoriano requested review from a team as code owners January 24, 2019 17:17
@webmat
Copy link
Contributor

webmat commented Jan 24, 2019

In ECS, network.direction is really meant for packets and connections. You should not split the network state metrics in two. In short, here's how I see it:

  • Don't populate network.direction, as this is a state you're sending.
  • Keep all the metrics in.*, out.*, errors, dropped etc exactly as they are.
  • You are correct about network.name, it's not for devices, there's nothing for network devices yet in ECS, so leave as is.

@webmat
Copy link
Contributor

webmat commented Jan 24, 2019

Note that for socket it's different. Since there's a direct relation between the metricbeat event and one socket, network.[direction|transport|bytes|packets] all make sense there

@jsoriano
Copy link
Member Author

Ok, so I leave then everything as is for this metricset, easy 😉

@jsoriano jsoriano closed this Jan 24, 2019
@ruflin ruflin mentioned this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs further discussion. ecs in progress Pull request is currently in progress. Metricbeat Metricbeat module Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants