Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase script compilations rate for Filebeat system tests #10388

Conversation

ycombinator
Copy link
Contributor

Partial backport of ##9777.

This PR ncreases the dynamic script compilations for Filebeat system tests to 1000/1m.

@ycombinator
Copy link
Contributor Author

This PR became necessary because a recent PR to 6.x — #10385 — started failing Jenkins CI with errors like so:

not error expected but got: {u'first_char': u'[', u'log': {u'file': {u'path': u'/go/src/github.com/elastic/beats/filebeat/module/elasticsearch/audit/test/test-access.log'}}, u'service': {u'name': u'elasticsearch'}, u'beat': {u'hostname': u'943053ccf5d3', u'name': u'943053ccf5d3', u'version': u'6.7.0'}, u'error': {u'message': u'[script] Too many dynamic script compilations within, max: [75/5m]; please use indexed, or scripts with parameters instead; this limit can be changed by the [script.max_compilations_rate] setting'}, u'fileset': {u'name': u'audit', u'module': u'elasticsearch'}, u'event': {u'dataset': u'elasticsearch.audit', u'created': u'2019-01-29T02:54:42.915Z'}, u'source': u'/go/src/github.com/elastic/beats/filebeat/module/elasticsearch/audit/test/test-access.log', u'host': {u'name': u'943053ccf5d3'}, u'offset': 0, u'input': {u'type': u'log'}, u'message': u'[2018-06-19T05:16:15,549] [rest] [authentication_failed]        origin_address=[147.107.128.77], principal=[i030648], uri=[/_xpack/security/_authenticate]', u'prospector': {u'type': u'log'}}

https://beats-ci.elastic.co/job/elastic+beats+pull-request+multijob-linux/4286/beat=filebeat,label=ubuntu/testReport/junit/test_modules/Test/test_fileset_file_42_elasticsearch/

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe this should be reverted after #9821 is done.

@ycombinator ycombinator merged commit 58c0488 into elastic:6.x Jan 29, 2019
@ycombinator ycombinator deleted the fb-systests-increase-dyn-script-compilations branch December 25, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Filebeat Filebeat review Team:Integrations Label for the Integrations team :Testing v6.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants