Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group_measurements_by_instance_label flag to perfmon configuration #11002

Merged
merged 2 commits into from
Mar 1, 2019

Conversation

jsoriano
Copy link
Member

Fixes #8688 after reverting in #11001.

Co-authored-by: Josh Smith j_smith95@live.com

ramenjosh and others added 2 commits February 28, 2019 22:45
elastic#8688)

This flag will send all perfmon measurements with a matching instance label as part of the same event (i.e. all metrics for C:, Processor X, etc.). This addresses some of the issues raised in elastic#6584.

In most cases enabling this flag considerably reduces the number of events sent by metricbeat.
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When you squash double check that the co-author tag is in the message.

@jsoriano jsoriano merged commit 81f00f7 into elastic:master Mar 1, 2019
@jsoriano jsoriano deleted the perfom-grouping branch March 1, 2019 10:17
@jsoriano
Copy link
Member Author

jsoriano commented Mar 1, 2019

Merged, thanks @andrewkroh for your help here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants