-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PYTHON_EXE env var as the python interpreter #11212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
force-pushed
the
feature/python-ve
branch
from
March 12, 2019 17:57
b0e1da0
to
da18d69
Compare
andrewkroh
changed the title
Use .python-version to determine virtualenv interpreter
Use PYTHON_EXE env var as the python interpreter
Mar 12, 2019
LGTM. We should get this in rather soonish. The creation of the extra virtualenv |
andrewkroh
force-pushed
the
feature/python-ve
branch
from
March 14, 2019 22:58
da18d69
to
366de74
Compare
Setting the PYTHON_EXE environment variable causes new Python virtual environments to be created using the specified interpreter. Both `make` and `mage` honor the variable. For example, `PYTHON_EXE=python2.7 make python-env`. Add changelog
andrewkroh
force-pushed
the
feature/python-ve
branch
from
March 14, 2019 22:59
366de74
to
e70758e
Compare
@urso I added a changelog entry and squashed the first commit that was off the mark. |
urso
approved these changes
Mar 15, 2019
@andrewkroh Please backport to 6.7 and 7.0 branches. |
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Apr 1, 2019
Setting the PYTHON_EXE environment variable causes new Python virtual environments to be created using the specified interpreter. Both `make` and `mage` honor the variable. For example, `PYTHON_EXE=python2.7 make python-env`. (cherry picked from commit 9fb274a)
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Apr 1, 2019
Setting the PYTHON_EXE environment variable causes new Python virtual environments to be created using the specified interpreter. Both `make` and `mage` honor the variable. For example, `PYTHON_EXE=python2.7 make python-env`. (cherry picked from commit 9fb274a)
andrewkroh
added a commit
that referenced
this pull request
Apr 4, 2019
…preter (#11569) * Use PYTHON_EXE env var as the python interpreter (#11212) Setting the PYTHON_EXE environment variable causes new Python virtual environments to be created using the specified interpreter. Both `make` and `mage` honor the variable. For example, `PYTHON_EXE=python2.7 make python-env`. (cherry picked from commit 9fb274a)
andrewkroh
added a commit
that referenced
this pull request
Apr 4, 2019
…preter (#11570) * Use PYTHON_EXE env var as the python interpreter (#11212) Setting the PYTHON_EXE environment variable causes new Python virtual environments to be created using the specified interpreter. Both `make` and `mage` honor the variable. For example, `PYTHON_EXE=python2.7 make python-env`. (cherry picked from commit 9fb274a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the PYTHON_EXE environment variable causes new Python virtual environments
to be created using the specified interpreter.
For example,
PYTHON_EXE=python2.7 make python-env
.