Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PYTHON_EXE env var as the python interpreter #11212

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Mar 12, 2019

Setting the PYTHON_EXE environment variable causes new Python virtual environments
to be created using the specified interpreter.

For example, PYTHON_EXE=python2.7 make python-env.

@andrewkroh andrewkroh changed the title Use .python-version to determine virtualenv interpreter Use PYTHON_EXE env var as the python interpreter Mar 12, 2019
@urso
Copy link

urso commented Mar 14, 2019

LGTM. We should get this in rather soonish. The creation of the extra virtualenv ve via mage did break our build system for some users having a mix of python2 and python3 installed (notabliy me :P ).

@andrewkroh andrewkroh marked this pull request as ready for review March 14, 2019 22:54
@andrewkroh andrewkroh requested a review from a team as a code owner March 14, 2019 22:54
Setting the PYTHON_EXE environment variable causes new Python virtual environments
to be created using the specified interpreter. Both `make` and `mage` honor the
variable.

For example, `PYTHON_EXE=python2.7 make python-env`.

Add changelog
@andrewkroh
Copy link
Member Author

@urso I added a changelog entry and squashed the first commit that was off the mark.

@andrewkroh andrewkroh merged commit 9fb274a into elastic:master Mar 15, 2019
@urso
Copy link

urso commented Apr 1, 2019

@andrewkroh Please backport to 6.7 and 7.0 branches.

andrewkroh added a commit to andrewkroh/beats that referenced this pull request Apr 1, 2019
Setting the PYTHON_EXE environment variable causes new Python virtual environments
to be created using the specified interpreter. Both `make` and `mage` honor the
variable.

For example, `PYTHON_EXE=python2.7 make python-env`.

(cherry picked from commit 9fb274a)
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Apr 1, 2019
Setting the PYTHON_EXE environment variable causes new Python virtual environments
to be created using the specified interpreter. Both `make` and `mage` honor the
variable.

For example, `PYTHON_EXE=python2.7 make python-env`.

(cherry picked from commit 9fb274a)
andrewkroh added a commit that referenced this pull request Apr 4, 2019
…preter (#11569)

* Use PYTHON_EXE env var as the python interpreter (#11212)

Setting the PYTHON_EXE environment variable causes new Python virtual environments
to be created using the specified interpreter. Both `make` and `mage` honor the
variable.

For example, `PYTHON_EXE=python2.7 make python-env`.

(cherry picked from commit 9fb274a)
andrewkroh added a commit that referenced this pull request Apr 4, 2019
…preter (#11570)

* Use PYTHON_EXE env var as the python interpreter (#11212)

Setting the PYTHON_EXE environment variable causes new Python virtual environments
to be created using the specified interpreter. Both `make` and `mage` honor the
variable.

For example, `PYTHON_EXE=python2.7 make python-env`.

(cherry picked from commit 9fb274a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants