[metricbeat] migrate vsphere/host to ReporterV2 #11403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
Metricbeat
ruflin
suggested changes
Mar 25, 2019
|
|
||
| events, err := f.Fetch() | ||
| f := mbtest.NewReportingMetricSetV2Error(t, getConfig(ts)) | ||
| events, errs := mbtest.ReportingFetchV2Error(f) | ||
| if err != nil { |
There was a problem hiding this comment.
I think this line should be removed as it checks an error from above.
There was a problem hiding this comment.
Good catch!
| @@ -24,8 +24,8 @@ import ( | |||
| ) | |||
|
|
|||
| func eventMapping(hs mo.HostSystem) common.MapStr { | |||
| totalCpu := int64(hs.Summary.Hardware.CpuMhz) * int64(hs.Summary.Hardware.NumCpuCores) | |||
| freeCpu := int64(totalCpu) - int64(hs.Summary.QuickStats.OverallCpuUsage) | |||
| totalCPU := int64(hs.Summary.Hardware.CpuMhz) * int64(hs.Summary.Hardware.NumCpuCores) | |||
There was a problem hiding this comment.
Thanks for the naming cleanup
62 tasks
ruflin
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #10774
Discovered something somewhat troubling here, which is that the
eventMappingfunction indata.goisn't used anywhere inFetch(). It has a test, but that's it.