Extend logstash.node_stats metricset for logstash_stats stack monitoring data #11511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 28, 2019
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package node_stats |
There was a problem hiding this comment.
don't use an underscore in package name
39 tasks
ycombinator
added
Metricbeat
|
Pinging @elastic/stack-monitoring |
|
jenkins, test this |
1 similar comment
|
jenkins, test this |
ruflin
reviewed
Jun 26, 2019
|
|
||
| type commonStats struct { | ||
| Events map[string]interface{} `json:"events"` | ||
| JVM map[string]interface{} `json:"jvm"` |
There was a problem hiding this comment.
@felixbarny @axw Just found some more jvm metrics. I wonder if long term this also ties into our metrics discussion: elastic/ecs#474
cachedout
approved these changes
Jun 26, 2019
@ruflin Not right away. I want to deliberately keep this set minimal to start out. It's easier to add more later than take away ones we don't need. So I'd rather add metrics as/when users request them. |
|
Chatted with @ruflin off-PR and he's given his LGTM. So I'm going ahead with the merge. |
ycombinator
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
node_statsmetricset in thelogstashmetricbeat module. It teaches it to understand thexpack.enabledsetting inmodules.d/logstash.yml. If this setting is set, the metricset indexeslogstash_statsdocuments in.monitoring-logstash-*indices.Resolves partially: #7035
Testing this PR
Start up a Logstash node running one or more pipelines.
Build Metricbeat with this PR:
Enable the logstash Metricbeat module:
Note:
metricbeat modules enable logstash-xpackwill not work as it has not been implemented yet.Configure the logstash Metricbeat module for X-Pack Monitoring. To do this, edit
modules.d/logstash.ymland add the following line to it:Start Metricbeat:
Query the
.monitoring-logstash-7-mb-*indices to make sure there are documents withtype: logstash_stats.Repeat the query in 6. above multiple times over the course of a minute or so. Make sure the number of documents grows over time. New documents of
type:logstash_statsshould be created every 10 seconds (corresponding to the defaultperiodinmodules.d/logstash.yml).