Add missing migrated fields for system module. #11545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 29, 2019 13:51
webmat
added
ecs
needs_backport
10 tasks
|
I've adjusted the dashboards manually, and I have an opinionated editor config that removes trailing spaces. So make sure to adjust your diff settings to ignore whitespace, when checking the dashboards :-) |
|
@fearful-symmetry Hey I'd appreciate your 👀on this PR 🙂 I've made my changes to the dashboards manually, and I know you were running the script that does that earlier. |
|
LGTM, with the usual caveat that I've been digging into ECS for all of 2-3 days. |
|
Merging now, as I want to get this backport started ASAP. Only two remaining tests are for metricbeat, and have nothing to do with these changes |
webmat
added a commit
to webmat/beats
that referenced
this pull request
Mar 29, 2019
* This adds all missing migrated fields for the system module to ecs-migration.yml * The breaking changes doc has been updated accordingly with script/renamed_fields.py * The corresponding dashboards for the system module have been updated manually (sorry for all the whitespace diff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My initial PR (#9138) migrated them in the fields def, but the ecs-migration.yml
file had missing fields, and one incorrectly named.
This PR fixes the ecs-mig.yml file, the breaking changes page and the
system module dashboards.
Needs to be backported to 7.0