[Auditbeat] Cherry-pick #11667 to 7.0: Log error when Homebrew not installed #11948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `package` dataset on macOS to logging an error when Homebrew is not installed instead of failing to start altogether. It will keep checking and start sending events as usual in case Homebrew is installed later. (cherry picked from commit bbe4991)
cwurm
changed the title
|
Pinging @elastic/secops |
andrewkroh
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #11667 to 7.0 branch. Original message:
At the moment, if Auditbeat is run with the default configuration (where the
packagedataset is enabled) on a Mac where Homebrew is not installed it will fail to start.This changes the behavior to only logging an error message:
2019-04-05T15:03:01.250+0100 ERROR [package] package/package.go:218 Failed to start package dataset on macOS. Error looking up /usr/local/Cellar - is Homebrew installed? Error: stat /usr/local/Cellar: no such file or directory