Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close changelog for 7.0.1 #11959

Merged
merged 1 commit into from
May 1, 2019
Merged

Close changelog for 7.0.1 #11959

merged 1 commit into from
May 1, 2019

Conversation

mikemadden42
Copy link
Contributor

No description provided.

@mikemadden42 mikemadden42 requested a review from a team as a code owner April 26, 2019 19:15
@mikemadden42 mikemadden42 requested review from a team as code owners April 30, 2019 16:09
@mikemadden42 mikemadden42 requested a review from ph April 30, 2019 16:11
@mikemadden42 mikemadden42 requested a review from kvch April 30, 2019 16:20
@webmat
Copy link
Contributor

webmat commented Apr 30, 2019 •
edited
Loading

I think there's things missing. I've fixed #11675 (backport #11766) after 7.0.0. So this changelog entry is missing.

But I assume this also means other things are missing in this 7.0.1 changelog?

@mikemadden42
Copy link
Contributor Author

I think there's things missing. I've fixed #11675 (backport #11766) after 7.0.0. So this changelog entry is missing.

But I assume this also means other things are missing in this 7.0.1 changelog?

I'm seeing this in CHANGELOG.asciidoc. I'm learning the release process, so it's possible I missed something.

- Fix formatting for `event.duration`, "human readable" was not working well for this. {pull}11675[11675]

@webmat
Copy link
Contributor

webmat commented Apr 30, 2019

The addition of the changelog.next file is also somewhat recent (a few months) + the fact that I don't often play in Beats = I may have messed it up on my end too ;-)

But my PR is definitely post 7.0.0.

@schersh schersh mentioned this pull request Apr 30, 2019
Closed
@urso urso merged commit 9610644 into elastic:7.0 May 1, 2019
@mikemadden42 mikemadden42 deleted the close_changelog_7.0.1 branch May 1, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@cachedout cachedout cachedout approved these changes

@urso urso urso approved these changes

@ph ph ph approved these changes

@kvch kvch Awaiting requested review from kvch

Assignees
No one assigned
Labels
docs release review v7.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikemadden42 @webmat @ph @urso @cachedout @andrewkroh