[Auditbeat] Package: Close librpm handle #12215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes the librpm handle we
dlopen()
when the dataset is closed.Lots of lines changed because I expanded and renamed
cFun
to belibrpm
, but the important part is saving the handle aslibrpm.handle
and closing it in the newcloseDataset()
function.Following #12168 this further reduces the leftover memory Valgrind reports (running
valgrind --leak-check=full --show-leak-kinds=all ./auditbeat -e -d "*"
):Before
After
I'm not sure where the remainder is coming from, or if those numbers are even valid given that Valgrind is not really compatible with Golang.