[6.8] Only log error (don't also index it) if xpack is enabled. (#12353) #12379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only log error (don't also index it) if xpack is enabled. * Adding CHANGELOG entry
ruflin
reviewed
Jun 3, 2019
| elastic.ReportAndLogError(err, r, m.Log) | ||
| return | ||
| } | ||
| return eventMapping(r, content) |
There was a problem hiding this comment.
This should stay as before as we don't have the new framework in 6.8?
There was a problem hiding this comment.
Note the name of this function. It's a function that is specific to this metricset, not part of the mb.MetricSet interface.
| } | ||
| } | ||
|
|
||
| func (m *MetricSet) fetchSettings(r mb.ReporterV2, now time.Time) { | ||
| func (m *MetricSet) fetchSettings(r mb.ReporterV2, now time.Time) error { |
There was a problem hiding this comment.
I think I'm now confused. Do we already support this in 6.8?
There was a problem hiding this comment.
Note the name of this function. It's a function that is specific to this metricset, not part of the mb.MetricSet interface.
ruflin
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.8: