Validate stack modules' metricsets when xpack.enabled = true #12386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
enhancement
review
needs_backport
|
Pinging @elastic/stack-monitoring |
houndci-bot
reviewed
Jun 1, 2019
houndci-bot
reviewed
Jun 1, 2019
ruflin
approved these changes
Jun 3, 2019
cachedout
reviewed
Jun 3, 2019
|
jenkins, test this |
|
@cachedout I addressed your comment from the previous round of review. Mind re-reviewing this PR? |
cachedout
approved these changes
Jun 4, 2019
ycombinator
force-pushed
the
mb-xp-validate-metricsets
branch
from
0229f05
to
96b3a91
Compare
|
jenkins, test this |
This was referenced Jun 4, 2019
ycombinator
added a commit
that referenced
this pull request
Jun 5, 2019
…12386) (#12431) * Validate stack modules' metricsets when xpack.enabled = true (#12386) * Checking validity of elasticsearch module with xpack.enabled * Refactoring: extracting validation function * Make the hound happy * More generic comment language * Implement validation for kibana module * Adding CHANGELOG entry * Fixing up CHANGELOG
andrewvc
pushed a commit
to andrewvc/beats
that referenced
this pull request
Jun 12, 2019
…#12386) * Checking validity of elasticsearch module with xpack.enabled * Refactoring: extracting validation function * Make the hound happy * More generic comment language * Implement validation for kibana module * Adding CHANGELOG entry
This was referenced Jun 23, 2019
ycombinator
removed
the
needs_backport
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lastic#12386) (elastic#12429) * Checking validity of elasticsearch module with xpack.enabled * Refactoring: extracting validation function * Make the hound happy * More generic comment language * Implement validation for kibana module * Adding CHANGELOG entry
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lastic#12386) (elastic#12430) * Checking validity of elasticsearch module with xpack.enabled * Refactoring: extracting validation function * Make the hound happy * More generic comment language * Implement validation for kibana module * Adding CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12327.
When the
elasticsearchorkibanametricbeat modules are enabled and thexpack.enabledflag in the module configuration is set totrue, an exact set of metricsets is required to be configured for Stack Monitoring to work correctly. This PR implements the necessary validation.