[libbeat] AWS ELB Monitoring #12401
Merged
[libbeat] AWS ELB Monitoring #12401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In heartbeat we have separate notions of jobs and tasks. This can make following the code and sharing the code among monitors confusing. This patch unifies the two. There is a tiny amount of extra execution overhead. Tasks only passed a single `common.MapStr`, where we now pass a `*beat.Event`, however, the benefit is that we have a more consistent and simple codebase.
Checkpoint Checkpoint Simpler concurrency for ELB autodiscover More cleanup Checkpoint Checkpoint Improve hash consistency for aws elb autodisco Moar moar Tighten up for initial review Revert changes to autodiscover.go Add preliminary docs Improved docs Improved Improved Moar AWS MULTI START
andrewvc
added
enhancement
Heartbeat
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime |
houndci-bot
reviewed
Jun 3, 2019
houndci-bot
reviewed
Jun 3, 2019
|
🙈 😄 interesting, we are currently talking about adding EC2 autodiscover provider! cc @kaiyan-sheng |
houndci-bot
reviewed
Jun 7, 2019
houndci-bot
reviewed
Jun 7, 2019
jsoriano
approved these changes
Jul 24, 2019
|
@jsoriano I made some material improvements in andrewvc/beats@282cec2...a5340f1 would you mind giving me one final approval? I found some bugs in manual testing that are now fixed. |
jsoriano
approved these changes
Jul 25, 2019
|
Failure is unrelated |
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Jul 30, 2019
Experimental autodiscovery provider for AWS ELBs. (cherry picked from commit 2c85c97)
andrewvc
added a commit
that referenced
this pull request
Jul 30, 2019
urso
pushed a commit
to urso/beats
that referenced
this pull request
Aug 2, 2019
This reverts commit a82ed33.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autodiscovery provider for AWS ELBs.
Not a lot to add besides that, the rest is in the docs provided within this PR.
One open question is the amount of testing to do here. We're still not sure if we want to introduce this as a beta feature, which might change the answer there. Ultimately, the AWS library is very tricky to mock. There is an elasticloadbalancingv2iface package that supposedly makes things easier, but realistically, you have to implement so much the value of that is dubious. Real functional testing with the AWS APIs is probably the only satisfactory answer, but that too is a significant investment.