Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow delete and index actions with a document ID #12606

Merged
merged 17 commits into from
May 6, 2020
Merged

Allow delete and index actions with a document ID #12606

merged 17 commits into from
May 6, 2020

Commits on Apr 29, 2020

  1. Add op_type meta key for delete and index operations with a documen… 

    …t ID.
    @bestpath-gb
    bestpath-gb committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    7ac1280 View commit details
    Browse the repository at this point in the history

  2. Add note on why obj can be nil.

    @bestpath-gb
    bestpath-gb committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    a054ab5 View commit details
    Browse the repository at this point in the history

  3. Refactor and extract consts.

    @bestpath-gb
    bestpath-gb committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    e32ca09 View commit details
    Browse the repository at this point in the history

  4. Don't include metadata prefix in key.

    @bestpath-gb
    bestpath-gb committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    8713bd6 View commit details
    Browse the repository at this point in the history

  5. Stop appending nil else it ends up in the body.

    @bestpath-gb
    bestpath-gb committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    fa44486 View commit details
    Browse the repository at this point in the history

  6. Error when trying to delete with no _id.

    @bestpath-gb
    bestpath-gb committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    1245360 View commit details
    Browse the repository at this point in the history

  7. Remove incorrect detail in comment.

    @bestpath-gb
    bestpath-gb committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    722dd71 View commit details
    Browse the repository at this point in the history

  8. Add unit test for new op_type meta key.

    @bestpath-gb
    bestpath-gb committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    932f954 View commit details
    Browse the repository at this point in the history

  9. No longer required.

    @bestpath-gb
    bestpath-gb committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    99c2bf2 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. Return error to caller.

    @bestpath-gb
    bestpath-gb committed May 4, 2020
    Configuration menu
    Copy the full SHA
    0ef2a12 View commit details
    Browse the repository at this point in the history

  2. Fail event if op_type is no string.

    @bestpath-gb
    bestpath-gb committed May 4, 2020
    Configuration menu
    Copy the full SHA
    dc0a7b1 View commit details
    Browse the repository at this point in the history

  3. Use consts in error.

    @bestpath-gb
    bestpath-gb committed May 4, 2020
    Configuration menu
    Copy the full SHA
    40a22d9 View commit details
    Browse the repository at this point in the history

  4. Replace assert with require.

    @bestpath-gb
    bestpath-gb committed May 4, 2020
    Configuration menu
    Copy the full SHA
    a541783 View commit details
    Browse the repository at this point in the history

  5. Fail instead of panic.

    @bestpath-gb
    bestpath-gb committed May 4, 2020
    Configuration menu
    Copy the full SHA
    ef3883b View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Change missed assert calls to require.

    @bestpath-gb
    bestpath-gb committed May 5, 2020
    Configuration menu
    Copy the full SHA
    140e74f View commit details
    Browse the repository at this point in the history

  2. Simplify GetMetaStringValue.

    @bestpath-gb
    bestpath-gb committed May 5, 2020
    Configuration menu
    Copy the full SHA
    d084e89 View commit details
    Browse the repository at this point in the history

  3. Ignore err as key may not exist.

    @bestpath-gb
    bestpath-gb committed May 5, 2020
    Configuration menu
    Copy the full SHA
    8ddf373 View commit details
    Browse the repository at this point in the history