Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix module config defaults in light modules #12674

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Fix module config defaults in light modules #12674

merged 2 commits into from
Jun 27, 2019

Commits on Jun 25, 2019

  1. Fix module config defaults in ligth modules 

    Use common base module builder when creating the base module for light
modules, so same defaults are set and same checks are executed. Without
this change there are errors if values that have defaults like `period`
are not set.
    @jsoriano
    jsoriano committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    308be27 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. Fix test that should have detected this

    @jsoriano
    jsoriano committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    5e7c055 View commit details
    Browse the repository at this point in the history