Cleaned up Include_body_for, added additional debugging and Added Exclude_body_for option #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved Initialization for Http.Include_body_for to Initialization function Added Varable checking before setting values for config varables Added Debugging to Initialization function logging Debug as http Changed Debug Level of shouldInclude to httpdetailed from http
I removed a code section at ~line 403 to 406 which should not have been. I restored those lines
|
I watched the CI Build and it looks like the Master Branch is failing so it does not look like this PR broke the tests, but if I get a chance tonight I will review |
|
Never mind, I re-checked out my fork, seems I broke something, going to cancel this pull request till I discover what is up |
monicasarbu
added a commit
that referenced
this pull request
Dec 2, 2015
Merge adding per core support
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there was no easy way to include all content-try by default, so I added a way to handle an empty array Include_body_for=[]
Then I realized if I am including everything I might want to Exclude some things. So I implemented that option
I also noticed that none of the Http options were documented in the Config file (also noticed someone mentioning that in the issues list)
Added some extra debug to show which option is getting set
Move Debugging for "Printing" the http body from "http" to httpdetailed debug levels
I performed a quick test on the new Include_body_for =[] and Exclude_body_for=["image/"] seems to work well
[http]
Include_body_for=[]
Send_all_headers=true
Strip_authorization=false
Split_cookie=true