Require braces to be present for environment variable expansion #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // ${} is all ASCII, so bytes are fine for this operation. | ||
| i := 0 | ||
| for j := 0; j < len(s); j++ { | ||
| if s[j] == '$' && j+2 < len(s) && s[j+1] == '{' { |
There was a problem hiding this comment.
This is the only line that was changed from the os.Expand function.
andrewkroh
changed the title
| {"x${Z:D}", "xD"}, | ||
| {"x${Z:A B C D}", "xA B C D"}, // Spaces are allowed in the default. | ||
| {"x${Z:}", "x"}, | ||
|
|
||
| // Defaults don't work unless braces are used. | ||
| {"x$y:D", "xy:D"}, | ||
| // Un-matched braces are swallowed by the Go os.Expand function. |
There was a problem hiding this comment.
This unfortunately increases the chance of it showing up accidentally, right?
There was a problem hiding this comment.
Yeah, it does. I'll see about modify their code to remove this behavior. I didn't realize it did this until I started reading the code.
|
Merging this as is, to have it in alpha1. Remaining comments can be addressed in other PRs. |
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Apr 13, 2016
- Variable expressions cannot be split across newlines.
- Unterminated variable expressions cause errors rather than silently swallowing characters.
- Added an escape sequence for using a literal '${' value.
Follow up to issue elastic#1304
ruflin
pushed a commit
that referenced
this pull request
Apr 15, 2016
- Variable expressions cannot be split across newlines.
- Unterminated variable expressions cause errors rather than silently swallowing characters.
- Added an escape sequence for using a literal '${' value.
Follow up to issue #1304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs were updated in #1290.