-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converting generator.py to mage #13610
Converting generator.py to mage #13610
Conversation
So, this is far from done, but now we at least have all the setup commands we need ported over to mage. This will make it easier to standardize the beat/metricbeat make files, and should reduce some amount of boilerplate. |
Okay, my attempts to add some useful features like a |
35c095d
to
1703b71
Compare
Slowly working on porting the test. This commit will fail Ci due to #13741. Other than that, the tests should be working with the mage script. |
613a803
to
23e5d28
Compare
Okay, this should pass CI. Should. |
Alright, there we go. The make tests aren't working on my laptop, but they're working on CI. |
bc4fd5d
to
6730378
Compare
Did a quick update to the devguide. |
Okay, this is about ready to go out of draft. The only thing that still bugs me is the design of the generator config, and I feel like it should be a struct instead of a map. The idea is that if we need to add configuration items later down the line, it's sort of a one-step process that requires you to just add an item to that map. |
CI is related to the ongoing libbeat CI issues. |
c7dfec4
to
4296287
Compare
jenkins, test this |
4296287
to
fc71f75
Compare
b03bdc2
to
c7410e9
Compare
jenkins, test this |
1 similar comment
jenkins, test this |
Converting generator.py to mage
This is a draft as it still has a ways to go.
Right now, we're more or less at feature parity with the existing python script. The goal is to have it also replace the functionality of
make setup
as well, since that's a one-time operation that doesn't really need to be a separate command.type
validation checksbeat
template stuff while we're at it