Log monitoring bulk failures #14356
Merged
Log monitoring bulk failures #14356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 31, 2019
| @@ -548,9 +522,9 @@ func bulkCollectPublishFails( | |||
| return failed, stats | |||
| } | |||
|
|
|||
| func itemStatus(reader *jsonReader) (int, []byte, error) { | |||
| func ItemStatus(reader *JSONReader) (int, []byte, error) { | |||
There was a problem hiding this comment.
exported function ItemStatus should have comment or be unexported
| return | ||
| } | ||
|
|
||
| for i, _ := range events { |
There was a problem hiding this comment.
should omit 2nd value from range; this loop is equivalent to for i := range ...
houndci-bot
reviewed
Oct 31, 2019
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
ycombinator
force-pushed
the
lb-mon-log-bulk-failures
branch
3 times, most recently
from
73c8a72
to
34227f6
Compare
|
jenkins, test this |
ph
suggested changes
Nov 12, 2019
There was a problem hiding this comment.
Code is OK to me, but I think we should have some tests added to cover that behavior and especially if the remote system changes his behavior. I don't link how the 200 vs the 403 response code is handled in this scenario.
Looking at existing code, there is currently no unit tests for the ES/reporter and adding that to the existing python system tests might be complicated but still worth investigating.
Also for BulkReadToItems we can surely add a test for it?
| raw []byte | ||
| } | ||
| // BulkResult contains the result of a bulk API request. | ||
| type BulkResult json.RawMessage |
ycombinator
force-pushed
the
lb-mon-log-bulk-failures
branch
from
f6dbefd
to
d95bd5f
Compare
ph
approved these changes
Nov 13, 2019
ycombinator
force-pushed
the
lb-mon-log-bulk-failures
branch
from
d95bd5f
to
36d60bb
Compare
|
Travis CI is green. Jenkins CI failures are unrelated. Merging. |
This was referenced Nov 14, 2019
ycombinator
added a commit
that referenced
this pull request
Nov 19, 2019
* Log monitoring bulk failures (#14356) * Log monitoring bulk failures * Renaming function * Simplifying type * Removing extraneous second value * Adding godoc comments * Adding CHANGELOG entry * Clarifying log messages * WIP: adding unit test stubs * Fleshing out unit tests * [DOCS] Deprecate central management (#14104) (#14594) * State minimum Go version (#14400) (#14598) * [DOCS] Fix description of rename processor (#14408) (#14600) * Log monitoring bulk failures (#14356) * Log monitoring bulk failures * Renaming function * Simplifying type * Removing extraneous second value * Adding godoc comments * Adding CHANGELOG entry * Clarifying log messages * WIP: adding unit test stubs * Fleshing out unit tests * Fixing up CHANGELOG
ycombinator
added a commit
that referenced
this pull request
Nov 21, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Log monitoring bulk failures (elastic#14356) * Log monitoring bulk failures * Renaming function * Simplifying type * Removing extraneous second value * Adding godoc comments * Adding CHANGELOG entry * Clarifying log messages * WIP: adding unit test stubs * Fleshing out unit tests * [DOCS] Deprecate central management (elastic#14104) (elastic#14594) * State minimum Go version (elastic#14400) (elastic#14598) * [DOCS] Fix description of rename processor (elastic#14408) (elastic#14600) * Log monitoring bulk failures (elastic#14356) * Log monitoring bulk failures * Renaming function * Simplifying type * Removing extraneous second value * Adding godoc comments * Adding CHANGELOG entry * Clarifying log messages * WIP: adding unit test stubs * Fleshing out unit tests * Fixing up CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14303.
As reported in #14303, when the Elasticsearch monitoring reporter in libbeat sends a bulk API request to Elasticsearch, and that request fails, the errors are currently swallowed. This is because the actual response code for the bulk API request is
200 OK; the actual errors are embedded in the request's response body.This PR teaches the Elasticsearch monitoring reporter to parse the bulk API response and log any errors. For the parsing, the same code as the Elasticsearch output is reused.
Testing this PR
Start up Elasticsearch with security enabled. Make sure you know the password for the
elasticsuperuser.Create a role that grants necessary privileges for managing and writing to
metricbeat-*indices.Create a user with the above role.
Build Metricbeat with this PR.
Start Metricbeat with monitoring enabled and specifying the credentials of the above user for the
elasticsearchoutput.Verify that
metricbeat-*indices are being created and populated in Elasticsearch but no.monitoring-beats-*indices are being created.Verify that there are warnings in the log like so: