-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Fix parsing of Cisco ASA/FTD message 302021 #14519
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriansr
added
bug
Filebeat
Filebeat
needs_backport
PR is waiting to be backported to other branches.
Team:SIEM
labels
Nov 14, 2019
Pinging @elastic/siem (Team:SIEM) |
andrewkroh
approved these changes
Nov 18, 2019
This fixes (again) the format of ASA/FTD message code 302021 which wasn't clear between Cisco's docs and Logstash pattern in elastic#13259. Seems that a field can be either a port number or an ICMP code. To be safe it's better to just ignore this value.
adriansr
force-pushed
the
fix-cisco-302021-again
branch
from
November 19, 2019 09:32
4c0ac1f
to
45550c0
Compare
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Nov 19, 2019
This fixes (again) the format of ASA/FTD message code 302021 which wasn't clear between Cisco's docs and Logstash pattern in elastic#13259. Seems that a field can be either a port number or an ICMP code. To be safe it's better to just ignore this value. (cherry picked from commit 02fc1c0)
adriansr
added
v7.6.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Nov 19, 2019
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Nov 19, 2019
This fixes (again) the format of ASA/FTD message code 302021 which wasn't clear between Cisco's docs and Logstash pattern in elastic#13259. Seems that a field can be either a port number or an ICMP code. To be safe it's better to just ignore this value. (cherry picked from commit 02fc1c0)
adriansr
added a commit
that referenced
this pull request
Nov 19, 2019
…ssage 302021 (#14610) This fixes (again) the format of ASA/FTD message code 302021 which wasn't clear between Cisco's docs and Logstash pattern in #13259. Seems that a field can be either a port number or an ICMP code. To be safe it's better to just ignore this value. (cherry picked from commit 02fc1c0)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…14611) This fixes (again) the format of ASA/FTD message code 302021 which wasn't clear between Cisco's docs and Logstash pattern in elastic#13259. Seems that a field can be either a port number or an ICMP code. To be safe it's better to just ignore this value. (cherry picked from commit c0cb4fd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes (again) the format of ASA/FTD message code 302021 which wasn't clear between Cisco's docs and Logstash pattern in #13259.
Seems that a field can be either a port number or an ICMP code. To be safe it's better to just ignore this value.