[Metricbeat] Check length of the slice instead of comparing with nil in cloudwatch #14525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
added
bug
Metricbeat
odacremolbap
approved these changes
Nov 14, 2019
fearful-symmetry
approved these changes
Nov 14, 2019
kaiyan-sheng
added
v7.5.0
and removed
needs_backport
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ice instead of comparing with nil in cloudwatch (elastic#14538) * [Metricbeat] Check length of the slice instead of comparing with nil in cloudwatch (elastic#14525) * Check length of the slice instead of comparing with nil (cherry picked from commit a3b7d92) * Fix changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #14123, I realized when
tagsFilteris empty,tagsFilter != nilstill returns true. This PR is to fix this issue with using checking length of the slice instead.Empty slice and nil slice are different but both of them have zero length and capacity. For my own reference: https://yourbasic.org/golang/clear-slice/