[Metricbeat] Create ActiveMQ module #14580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
added
enhancement
module
needs_backport
exekias
reviewed
Nov 19, 2019
|
ey Marcin, is this one still in WIP? I think you can drop that from the title already 😸 Also, we have the |
mtojek
changed the title
|
You're right @exekias ! Totally forgot about it. |
exekias
approved these changes
Nov 19, 2019
added 17 commits
November 19, 2019 20:19
mtojek
force-pushed
the
14510-activemq-module
branch
from
70adc53 to
a368129
Compare
|
Just rebased against latest master |
Co-Authored-By: kaiyan-sheng <kaiyan.sheng@elastic.co>
|
Thanks! Changelog.next has been updated. |
|
As the PR got approved and Travis build passed, I will merge it to master. |
mtojek
added a commit
to mtojek/beats
that referenced
this pull request
Nov 26, 2019
* Generate bootstrap for broker, queue, topic * Update generated files * Define metricsets in disabler * Prepare docker image for ActiveMQ * Define jolokia endpoint in disabler * Convert to lightweight module * Remove downloaded installation bundle * Fill sample data.json * Refactor metricset fields * Update docs * Fix: do not expose ActiveMQ port * Fix: mage fmt update * Dockerfile: define healthcheck * Move module contents to x-pack * Fix: move docker-compose definition to x-pack * Add basic system test * Fix: update docs * System tests: topic metrics collected * Fix: mage fmt update * System tests: queue, topic metrics collected * Update docs * Fix: use compose_host * Assert that fields are documented * Fix: typo in metricbeat/docs/modules/activemq.asciidoc Co-Authored-By: kaiyan-sheng <kaiyan.sheng@elastic.co> * Add CHANGELOG.next entry * Fix: mage fmt update
mtojek
removed
the
needs_backport
mtojek
added a commit
that referenced
this pull request
Nov 26, 2019
* [Metricbeat] Create ActiveMQ module (#14580) * Generate bootstrap for broker, queue, topic * Update generated files * Define metricsets in disabler * Prepare docker image for ActiveMQ * Define jolokia endpoint in disabler * Convert to lightweight module * Remove downloaded installation bundle * Fill sample data.json * Refactor metricset fields * Update docs * Fix: do not expose ActiveMQ port * Fix: mage fmt update * Dockerfile: define healthcheck * Move module contents to x-pack * Fix: move docker-compose definition to x-pack * Add basic system test * Fix: update docs * System tests: topic metrics collected * Fix: mage fmt update * System tests: queue, topic metrics collected * Update docs * Fix: use compose_host * Assert that fields are documented * Fix: typo in metricbeat/docs/modules/activemq.asciidoc Co-Authored-By: kaiyan-sheng <kaiyan.sheng@elastic.co> * Add CHANGELOG.next entry * Fix: mage fmt update * Fix: import stomp in the function scope (#14703) * Fix: use metrics_path instead of path in system tests (#14690) * [Metricbeat] Create Kibana dashboards for ActiveMQ module (#14655) * Kibana dashboard: ActiveMQ broker overview * Fix: mage fmt update * Fix: invalid dashboard JSON * Kibana dashboard: ActiveMQ queues and topics overview * Add dashboard screenshots * Enable time units, pct in dashboards * Adjust PR reference in CHANGELOG.next * Fix: mage fmt update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking as WIP to let you review changes before I dive into testing and dashboards.
Issue: #14510
This PR introduces new Metricbeat module supporting ActiveMQ. The module collects metrics based on Jolokia REST endpoint.
As this is a lightweight module, I believe I can omit integration tests.
still TODO in this PR: