[Heartbeat] Record TLS Metadata for expired/invalid certs #14588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes elastic#13687 . Previously heartbeat would only traverse valid x509 cert chains, with this PR it now traverses all certs provided by the server.
andrewvc
added
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime (:uptime) |
ruflin
approved these changes
Nov 19, 2019
|
Build failures are unrelated. |
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Nov 19, 2019
) This patch fixes elastic#13687 . Previously heartbeat would only traverse valid x509 cert chains, with this PR it now traverses all certs provided by the server. (cherry picked from commit eff54c3)
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Nov 19, 2019
) This patch fixes elastic#13687 . Previously heartbeat would only traverse valid x509 cert chains, with this PR it now traverses all certs provided by the server. (cherry picked from commit eff54c3)
andrewvc
added a commit
that referenced
this pull request
Nov 20, 2019
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Nov 20, 2019
) This patch fixes elastic#13687 . Previously heartbeat would only traverse valid x509 cert chains, with this PR it now traverses all certs provided by the server. (cherry picked from commit eff54c3)
andrewvc
added a commit
that referenced
this pull request
Nov 22, 2019
andrewvc
added a commit
that referenced
this pull request
Nov 25, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
) (elastic#14621) This patch fixes elastic#13687 . Previously heartbeat would only traverse valid x509 cert chains, with this PR it now traverses all certs provided by the server. (cherry picked from commit b69ecd2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #13687 .
Previously heartbeat would only traverse valid x509 cert chains, with this PR it now traverses all certs provided by the server.
This also fixes the issue where no SSL metadata would be shown if validation was disabled.