Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Allow loading fielddata on _id field #14850

Merged
merged 1 commit into from
Nov 28, 2019
Merged

[Testing] Allow loading fielddata on _id field #14850

merged 1 commit into from
Nov 28, 2019

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Nov 28, 2019

Fixes issue reported in: #14849

This PR adjusts testing environment to recent changes introduced in Elasticsearch 8.0-SNAPSHOT: elastic/elasticsearch#49166 .

Without this change filebeat integration tests fail:

"Caused by: java.lang.IllegalArgumentException: Fielddata access on the _id field is disallowed, you can re-enable it by updating the dynamic cluster setting: indices.id_field_data.enabled",
"at org.elasticsearch.index.mapper.IdFieldMapper$IdFieldType$1.build(IdFieldMapper.java:172) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]",
"at org.elasticsearch.index.fielddata.IndexFieldDataService.getForField(IndexFieldDataService.java:134) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]",
"at org.elasticsearch.index.query.QueryShardContext.getForField(QueryShardContext.java:194) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]",

ChrsMark
ChrsMark approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!!!
The change looks good to me.

@ChrsMark ChrsMark requested a review from a team November 28, 2019 22:03
@mtojek mtojek merged commit 8859ead into elastic:master Nov 28, 2019
@axw axw mentioned this pull request Nov 29, 2019
Merged
ph added a commit to ph/beats that referenced this pull request Apr 22, 2021
@ph
Remove id_field_data from our docker compose file
7375f09 
The `id_field_data` was added in elastic#14850

From Elasticsearch's team recommendation this should not be used.
@ph ph mentioned this pull request Apr 22, 2021
Merged
6 tasks
ph added a commit that referenced this pull request Apr 26, 2021
@ph
Remove id_field_data from our docker compose file (#25239)
2ccf3d7 
* Remove id_field_data from our docker compose file

The `id_field_data` was added in #14850

From Elasticsearch's team recommendation this should not be used.

* Changelog
mergify bot pushed a commit that referenced this pull request Apr 26, 2021
@ph
Remove id_field_data from our docker compose file (#25239)
305af93 
* Remove id_field_data from our docker compose file

The `id_field_data` was added in #14850

From Elasticsearch's team recommendation this should not be used.

* Changelog

(cherry picked from commit 2ccf3d7)

# Conflicts:
#	testing/environments/snapshot.yml
mergify bot pushed a commit that referenced this pull request Apr 26, 2021
@ph
Remove id_field_data from our docker compose file (#25239)
eea83e3 
* Remove id_field_data from our docker compose file

The `id_field_data` was added in #14850

From Elasticsearch's team recommendation this should not be used.

* Changelog

(cherry picked from commit 2ccf3d7)

# Conflicts:
#	testing/environments/snapshot.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @ChrsMark