Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MQTT input to Filebeat #15287
Add MQTT input to Filebeat #15287
Changes from 3 commits
132d6c3
6c857d1
c95b351
3e96233
839a1f6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return err instead of panicking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should propagate
token.Error()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this line can potentially wait forever.
WaitTimeout
is probably a better choice. (Contexts or lifetime channels would be preferable but it looks like this library doesn't support them.) Same thing above inconnect
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message
andevent
are overloaded concepts here, prefer something more specific likemessage
->mqtt
(which is the subfield it ends up in) and maybeevent
->eventFields
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
event["isSystemTopic"] = strings.HasPrefix(msg.Topic(), "$")
also, prefer snake case for
beat.Event
fields (is_system_topic
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ID
->id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More naming nits :-) "Payload" is a redundant concept here (this function doesn't know or care what a payload is, it just decodes the given bytes), so
DecodeBytes
is more contextually clear. Also prefer non-exported (decodeBytes
). The comment should also say explicitly what "decoding" means (attempting msgpack -> json -> text).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this doesn't need
input
and could be a standalone helper. The name / description and comments are also a little misleading (no parsing is happening here), maybe a more descriptive name likesubscriptionsForTopics
which would also be more clear from the call site.