Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Use single data flag #15292

Merged
merged 4 commits into from
Jan 9, 2020
Merged

[Metricbeat] Use single data flag #15292

merged 4 commits into from
Jan 9, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Jan 2, 2020

This PR deprecates the following test flags - generate and update_expected, in favor of data.

Issue: #13531

@mtojek mtojek changed the title Use single data flag [Metricbeat] Use single data flag Jan 2, 2020
@mtojek mtojek self-assigned this Jan 2, 2020
@mtojek mtojek added Team:Integrations Label for the Integrations team [zube]: In Progress needs_backport PR is waiting to be backported to other branches. labels Jan 2, 2020
@mtojek mtojek marked this pull request as ready for review January 2, 2020 09:24
@mtojek mtojek requested a review from a team January 2, 2020 10:38
@mtojek mtojek requested a review from a team January 3, 2020 11:26
@exekias
Copy link
Contributor

exekias commented Jan 7, 2020

Thank you for starting this! it seems there are some issues with flag redefinition in tests, will need some more changes

@mtojek mtojek changed the title [Metricbeat] Use single data flag WIP: [Metricbeat] Use single data flag Jan 7, 2020
@mtojek
Copy link
Contributor Author

mtojek commented Jan 7, 2020

Thank you @exekias for your input! I admit that I missed this report because of flaky noise in tests. It should be ok now.

@mtojek mtojek changed the title WIP: [Metricbeat] Use single data flag [Metricbeat] Use single data flag Jan 7, 2020
jsoriano
jsoriano reviewed Jan 9, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! It LGTM, but we should probably add an entry to the developer changelog.

@mtojek
Copy link
Contributor Author

mtojek commented Jan 9, 2020

@jsoriano Thanks for the review! Developer changelog has been updated.

@mtojek mtojek requested a review from jsoriano January 9, 2020 15:52
@mtojek mtojek merged commit 77019e7 into elastic:master Jan 9, 2020
mtojek added a commit to mtojek/beats that referenced this pull request Jan 9, 2020
@mtojek
[Metricbeat] Use single data flag (elastic#15292)
b4f7e45 
* Use single data flag

* Change 'generate' references

* Initialize flags once

* Update developer CHANGELOG

(cherry picked from commit 77019e7)
@mtojek mtojek mentioned this pull request Jan 9, 2020
Merged
@mtojek mtojek added v7.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 9, 2020
mtojek added a commit that referenced this pull request Jan 9, 2020
@mtojek
[Metricbeat] Use single data flag (#15292) (#15432)
034d198 
* Use single data flag

* Change 'generate' references

* Initialize flags once

* Update developer CHANGELOG

(cherry picked from commit 77019e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng left review comments

@jsoriano jsoriano jsoriano approved these changes

Assignees

@mtojek mtojek

Labels
Team:Integrations Label for the Integrations team v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mtojek @exekias @jsoriano @kaiyan-sheng @andresrc