-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Add new page statistics to system/memory metricset #15492
Merged
fearful-symmetry
merged 11 commits into
elastic:master
from
fearful-symmetry:add-new-vmstat-data
Jan 14, 2020
Merged
[Metricbeat] Add new page statistics to system/memory metricset #15492
fearful-symmetry
merged 11 commits into
elastic:master
from
fearful-symmetry:add-new-vmstat-data
Jan 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I believe this level knowledge deserves a short paragraph in README.
unixsurfer
reviewed
Jan 13, 2020
@fearful-symmetry Thanks a lot for your work! It looks great, I only had on comment about the description for the efficiency field. |
Updated data.json and field descriptions. |
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Jan 14, 2020
…tic#15492) * add new page statistics to system/memory * update field descriptions * make update * update data.json * update system tests * update changelog * fix conflicts * try to fix system python tests (cherry picked from commit 0fd2250)
fearful-symmetry
added a commit
that referenced
this pull request
Jan 14, 2020
…etricset (#15527) * [Metricbeat] Add new page statistics to system/memory metricset (#15492) * add new page statistics to system/memory * update field descriptions * make update * update data.json * update system tests * update changelog * fix conflicts * try to fix system python tests (cherry picked from commit 0fd2250) * update fields * fix readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #13744
This adds a new set of page scan and reclaim metrics to the system/memory metricset, as requested in the original issue. I'm a tad hesitant do dump the entire
/proc/vmstat
metrics in here, since this metricset is relatively clean and has a a fairly consistent format that I'd rather not dirty with avmstat.*
group.These are fairly high-level metrics, so this adds a new
page_stats
group for them.Metrics added:
pgscan
metrics, measuring pages scannedpgsteal
metrics, measuring pages reclaimedpgfree
metric, measuring pages freed by the systemefficiency
metrics, measuring the efficiency of page reclaim.With regards to
efficiency
, I was hesitant to to copy thevmeff
metric from sar, as thepgscan
andpgsteal
metrics we get are much more detailed than whatsar
is collecting, so I instead copied thevmeff
metric into groups, that measure the same thing (reclaim efficiency) at a more detailed level.Test Plan