Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix convert processor conversion of string with leading zeros to integer #15557

Merged
merged 4 commits into from
Jan 15, 2020
Merged

Fix convert processor conversion of string with leading zeros to integer #15557

merged 4 commits into from
Jan 15, 2020

Commits on Jan 14, 2020

  1. Fix convert processor conversion of string to integer 

    The conversion failed when for strings with leading zeroes and a decimal
digit 8 or 9, as the underlying runtime function would try to parse that
as an octal number.

This is fixed by only allowing decimal and hex, which in turns makes the
processor more aligned to its Elasticsearch counterpart.

Fixes elastic#15513
    @adriansr
    adriansr committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    de47173 View commit details
    Browse the repository at this point in the history

  2. Add PR number and fix test

    @adriansr
    adriansr committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    733b4e4 View commit details
    Browse the repository at this point in the history

  3. Not so-silly hex check

    @adriansr
    adriansr committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    bb9436f View commit details
    Browse the repository at this point in the history

  4. Comment

    @adriansr
    adriansr committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    defd2b1 View commit details
    Browse the repository at this point in the history